[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 2/4] net: Remove the deprecated "vlan" parameter
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PULL 2/4] net: Remove the deprecated "vlan" parameter |
Date: |
Tue, 15 May 2018 10:10:05 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 05/14/2018 02:55 AM, Jason Wang wrote:
From: Thomas Huth <address@hidden>
It's been marked as deprecated since QEMU v2.9.0, so that should have
been enough time for everybody to either just drop unnecessary "vlan=0"
parameters, to switch to the modern -device + -netdev syntax for connecting
guest NICs with host network backends, or to switch to the "hubport" netdev
in case hubs are really wanted instead.
Buglink: https://bugs.launchpad.net/qemu/+bug/658904
Signed-off-by: Thomas Huth <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Signed-off-by: Jason Wang <address@hidden>
---
@@ -499,10 +497,11 @@
# @opts: device type specific properties (legacy)
#
# Since: 1.2
+#
+# 'vlan' - removed with 2.12
Shouldn't this be 2.13? Also, while the phrase 'removed with XXX'
already appears for NetClientDriver::dump, it sounds awkward; better
would be matching the way we document things for BlockDeviceInfo:
NetClientDriver
2.12: dropped 'dump'
...
NetLegacy
2.13: dropped 'vlan'
or the way we do it for QKeyCode:
NetClientDriver
dump: dropped in 2.12
...
NetLegacy
vlan: dropped in 2.13
As this is already in a pull request, and as NetClientDriver also needs
a cleanup, that can be a followup patch.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
- [Qemu-devel] [PULL 0/4] Net patches, Jason Wang, 2018/05/14
- [Qemu-devel] [PULL 1/4] net: Fix memory leak in net_param_nic(), Jason Wang, 2018/05/14
- [Qemu-devel] [PULL 2/4] net: Remove the deprecated "vlan" parameter, Jason Wang, 2018/05/14
- Re: [Qemu-devel] [PULL 2/4] net: Remove the deprecated "vlan" parameter,
Eric Blake <=
- [Qemu-devel] [PULL 3/4] net: Get rid of 'vlan' terminology and use 'hub' instead in the source files, Jason Wang, 2018/05/14
- [Qemu-devel] [PULL 4/4] net: Get rid of 'vlan' terminology and use 'hub' instead in the doc files, Jason Wang, 2018/05/14
- Re: [Qemu-devel] [PULL 0/4] Net patches, Peter Maydell, 2018/05/14