[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC] qemu-error: introduce error_report_once
From: |
Peter Xu |
Subject: |
Re: [Qemu-devel] [PATCH RFC] qemu-error: introduce error_report_once |
Date: |
Wed, 16 May 2018 11:08:58 +0800 |
User-agent: |
Mutt/1.9.3 (2018-01-21) |
On Tue, May 15, 2018 at 05:56:34PM +0200, Markus Armbruster wrote:
[...]
> I see.
>
> Add a contract comment (suggest to start with the one next to
> error_report()), expand the tabs, replace the reserved identifiers
> (caught by patchew; you can use foo_ instead of __foo), throw in at
> least one use to serve as a showcase (ideally one demonstrating the
> difference to trace points), and consider working some of your
> additional rationale into your commit message.
Will do. Thanks Markus.
--
Peter Xu
Re: [Qemu-devel] [PATCH RFC] qemu-error: introduce error_report_once, Stefan Hajnoczi, 2018/05/31