[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 2/5] qemu-options: Bail out on unsupported op
From: |
Anthony PERARD |
Subject: |
Re: [Qemu-devel] [PATCH v2 2/5] qemu-options: Bail out on unsupported options instead of silently ignoring them |
Date: |
Wed, 16 May 2018 17:49:00 +0100 |
User-agent: |
Mutt/1.9.5 (2018-04-13) |
On Fri, May 04, 2018 at 07:01:07PM +0200, Thomas Huth wrote:
> diff --git a/vl.c b/vl.c
> index 806eec2..457e93b 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -4042,7 +4042,10 @@ int main(int argc, char **argv, char **envp)
> }
> break;
> default:
> - os_parse_cmd_args(popt->index, optarg);
> + if (os_parse_cmd_args(popt->index, optarg)) {
> + error_report("Option not supported in this build");
> + exit(1);
> + }
I think that report false errors, I've got:
qemu-system-i386: -no-user-config: Option not supported in this build
Regards,
--
Anthony PERARD
- [Qemu-devel] [PATCH v2 0/5] Removal of deprecated -no-kvm* options, Thomas Huth, 2018/05/04
- [Qemu-devel] [PATCH v2 4/5] qemu-options: Remove deprecated -no-kvm-irqchip, Thomas Huth, 2018/05/04
- [Qemu-devel] [PATCH v2 1/5] qemu-options: Remove remainders of the -tdf option, Thomas Huth, 2018/05/04
- [Qemu-devel] [PATCH v2 3/5] qemu-options: Remove deprecated -no-kvm-pit-reinjection, Thomas Huth, 2018/05/04
- [Qemu-devel] [PATCH v2 2/5] qemu-options: Bail out on unsupported options instead of silently ignoring them, Thomas Huth, 2018/05/04
- Re: [Qemu-devel] [PATCH v2 2/5] qemu-options: Bail out on unsupported options instead of silently ignoring them,
Anthony PERARD <=
- [Qemu-devel] [PATCH v2 5/5] qemu-options: Remove deprecated -no-kvm, Thomas Huth, 2018/05/04
- Re: [Qemu-devel] [PATCH v2 0/5] Removal of deprecated -no-kvm* options, Paolo Bonzini, 2018/05/04
- Re: [Qemu-devel] [PATCH v2 0/5] Removal of deprecated -no-kvm* options, Thomas Huth, 2018/05/07
- Re: [Qemu-devel] [PATCH v2 0/5] Removal of deprecated -no-kvm* options, Markus Armbruster, 2018/05/07
- Re: [Qemu-devel] [PATCH v2 0/5] Removal of deprecated -no-kvm* options, Thomas Huth, 2018/05/07
- Re: [Qemu-devel] [PATCH v2 0/5] Removal of deprecated -no-kvm* options, Markus Armbruster, 2018/05/07
- Re: [Qemu-devel] [PATCH v2 0/5] Removal of deprecated -no-kvm* options, Paolo Bonzini, 2018/05/07
- Re: [Qemu-devel] [PATCH v2 0/5] Removal of deprecated -no-kvm* options, Markus Armbruster, 2018/05/07
- Re: [Qemu-devel] [PATCH v2 0/5] Removal of deprecated -no-kvm* options, Paolo Bonzini, 2018/05/07