[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 38/42] job: Add JOB_STATUS_CHANGE QMP event
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH 38/42] job: Add JOB_STATUS_CHANGE QMP event |
Date: |
Wed, 16 May 2018 22:46:49 +0200 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
Am 16.05.2018 um 21:26 hat Eric Blake geschrieben:
> On 05/09/2018 11:26 AM, Kevin Wolf wrote:
> > This adds a QMP event that is emitted whenever a job transitions from
> > one status to another. For the event, a new qapi/job.json schema file is
> > created which will contain all job-related definitions that aren't tied
> > to the block layer.
> >
> > Signed-off-by: Kevin Wolf <address@hidden>
> > ---
>
> > +++ b/qapi/job.json
>
> > +##
> > +# @JOB_STATUS_CHANGE:
> > +#
> > +# Emitted when a job transitions to a different status.
> > +#
> > +# @id: The job identifier
> > +# @status: The new job status
> > +#
> > +# Since: 2.13
> > +##
> > +{ 'event': 'JOB_STATUS_CHANGE',
> > + 'data': { 'id': 'str',
> > + 'status': 'JobStatus' } }
>
> Is it worth also trying to list the old state that the transition came from?
> But that's new compared to what block jobs are currently doing, so if we
> can't come up with a strong reason to add that, I'm okay.
If a management tool needs this information (I don't see why), it just
needs to keep track of the last state it had seen, no?
Kevin
- Re: [Qemu-devel] [PATCH 40/42] job: Add query-jobs QMP command, (continued)
[Qemu-devel] [PATCH 41/42] iotests: Move qmp_to_opts() to VM, Kevin Wolf, 2018/05/09
[Qemu-devel] [PATCH 42/42] qemu-iotests: Test job-* with block jobs, Kevin Wolf, 2018/05/09
[Qemu-devel] [PATCH 38/42] job: Add JOB_STATUS_CHANGE QMP event, Kevin Wolf, 2018/05/09
Re: [Qemu-devel] [PATCH 00/42] Generic background jobs, Kevin Wolf, 2018/05/15