|
From: | Richard Henderson |
Subject: | Re: [Qemu-devel] [PATCH v4 03/49] configure: add support for --cross-cc-FOO |
Date: | Thu, 17 May 2018 11:19:38 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 05/17/2018 10:46 AM, Alex Bennée wrote: > + if ! do_compiler $target_compiler -o $TMPE $TMPC -static ; then > + # For host systems we might get away with building without -static > + if ! do_compiler $target_compiler -o $TMPE $TMPC ; then > + target_compiler="" > + else > + enabled_cross_compilers="${enabled_cross_compilers} > ${target_compiler}" > + target_compiler_static="n" > + fi > + else > + enabled_cross_compilers="${enabled_cross_compilers} > ${target_compiler}" > + target_compiler_static="y" > + fi Better to order this with positive tests? if do_compiler $target_compiler -o $TMPE $TMPC -static ; then ... elif do_compiler $target_compiler -o $TMPE $TMPC ; then ... else ... fi Is there really a benefit to $target_compiler_static above adding -static to $cross_compiler_flags_FOO? r~
[Prev in Thread] | Current Thread | [Next in Thread] |