Re: [Qemu-devel] [PATCH 1/2] Add generic Nios II board.

[Philippe Mathieu-Daudé]

Hi Julian,

You should Cc the NiosII maintainers for faster review (done).

(From
https://wiki.qemu.org/Contribute/SubmitAPatch#CC_the_relevant_maintainer:)

$ ./scripts/get_maintainer.pl -f hw/nios2/
Chris Wulff <address@hidden> (maintainer:NiosII)
Marek Vasut <address@hidden> (maintainer:NiosII)

On 05/17/2018 07:38 PM, Julian Brown wrote:
> 
> This patch adds support for a generic MMU-less Nios II board that can
> be used e.g. for bare-metal compiler testing.  Nios II booting is also
> tweaked so that bare-metal binaries start executing in RAM starting at
> 0x00000000, rather than an alias at 0xc0000000, which allows features
> such as unwinding to work when binaries are linked to start at the
> beginning of the address space.
> 
> The generic_nommu.c parts are by Andrew Jenner, based on code by Marek
> Vasut.

Can you get/add their S-o-b?

> Signed-off-by: Julian Brown <address@hidden>
> ---
>  hw/nios2/Makefile.objs   |   2 +-
>  hw/nios2/boot.c          |   5 +-
>  hw/nios2/generic_nommu.c | 128 
> +++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 133 insertions(+), 2 deletions(-)
>  create mode 100644 hw/nios2/generic_nommu.c

It seems your email client messed your patch up, see
https://wiki.qemu.org/Contribute/SubmitAPatch#Do_not_send_as_an_attachment

Can you resend?

Regards,

Phil.

signature.asc
Description: OpenPGP digital signature