[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3] monitor: let cur_mon be per-thread
From: |
Peter Xu |
Subject: |
Re: [Qemu-devel] [PATCH v3] monitor: let cur_mon be per-thread |
Date: |
Tue, 22 May 2018 11:48:53 +0800 |
User-agent: |
Mutt/1.9.5 (2018-04-13) |
On Thu, Apr 12, 2018 at 02:11:08PM +0800, Peter Xu wrote:
> In the future the monitor iothread may be accessing the cur_mon as
> well (via monitor_qmp_dispatch_one()). Before we introduce a real
> Out-Of-Band command, let's convert the cur_mon variable to be a
> per-thread variable to make sure there won't be a race between threads.
>
> Note that thread variables are not initialized to a valid value when new
> thread is created. However for our case we don't need to set it up,
> since the cur_mon variable is only used in such a pattern:
>
> old_mon = cur_mon;
> cur_mon = xxx;
> (do something, read cur_mon if necessary in the stack)
> cur_mon = old_mon;
>
> It plays a role as stack variable, so no need to be initialized at all.
> We only need to make sure the variable won't be changed unexpectedly by
> other threads.
>
> Signed-off-by: Peter Xu <address@hidden>
> ---
> v3:
> - fix code style warning from patchew
> v2:
> - drop qemu-thread changes
Ping?
--
Peter Xu
- Re: [Qemu-devel] [PATCH v3] monitor: let cur_mon be per-thread,
Peter Xu <=
- Re: [Qemu-devel] [PATCH v3] monitor: let cur_mon be per-thread, Markus Armbruster, 2018/05/23
- Re: [Qemu-devel] [PATCH v3] monitor: let cur_mon be per-thread, Peter Xu, 2018/05/23
- Re: [Qemu-devel] [PATCH v3] monitor: let cur_mon be per-thread, Markus Armbruster, 2018/05/23
- Re: [Qemu-devel] [PATCH v3] monitor: let cur_mon be per-thread, Peter Xu, 2018/05/24
- Re: [Qemu-devel] [PATCH v3] monitor: let cur_mon be per-thread, Markus Armbruster, 2018/05/24
- Re: [Qemu-devel] [PATCH v3] monitor: let cur_mon be per-thread, Peter Xu, 2018/05/24
- Re: [Qemu-devel] [PATCH v3] monitor: let cur_mon be per-thread, Markus Armbruster, 2018/05/24