[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 2/6] vga-pci: use PCI_VGA_MMIO_SIZE
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH v2 2/6] vga-pci: use PCI_VGA_MMIO_SIZE |
Date: |
Tue, 22 May 2018 17:50:27 -0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 05/22/2018 01:50 PM, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> hw/display/vga-pci.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/hw/display/vga-pci.c b/hw/display/vga-pci.c
> index fb3e4cd400..700ac58c69 100644
> --- a/hw/display/vga-pci.c
> +++ b/hw/display/vga-pci.c
> @@ -232,7 +232,8 @@ static void pci_std_vga_realize(PCIDevice *dev, Error
> **errp)
>
> /* mmio bar for vga register access */
> if (d->flags & (1 << PCI_VGA_FLAG_ENABLE_MMIO)) {
> - memory_region_init(&d->mmio, NULL, "vga.mmio", 4096);
> + memory_region_init(&d->mmio, NULL, "vga.mmio",
> + PCI_VGA_MMIO_SIZE);
>
> if (d->flags & (1 << PCI_VGA_FLAG_ENABLE_QEXT)) {
> qext = true;
> @@ -267,7 +268,8 @@ static void pci_secondary_vga_realize(PCIDevice *dev,
> Error **errp)
> s->con = graphic_console_init(DEVICE(dev), 0, s->hw_ops, s);
>
> /* mmio bar */
> - memory_region_init(&d->mmio, OBJECT(dev), "vga.mmio", 4096);
> + memory_region_init(&d->mmio, OBJECT(dev), "vga.mmio",
> + PCI_VGA_MMIO_SIZE);
>
> if (d->flags & (1 << PCI_VGA_FLAG_ENABLE_QEXT)) {
> qext = true;
>
- [Qemu-devel] [PATCH v2 0/6] display: add new bochs-display device, Gerd Hoffmann, 2018/05/22
- [Qemu-devel] [PATCH v2 6/6] MAINTAINERS: add vga entries, Gerd Hoffmann, 2018/05/22
- [Qemu-devel] [PATCH v2 5/6] bochs-display: add pcie support, Gerd Hoffmann, 2018/05/22
- [Qemu-devel] [PATCH v2 2/6] vga-pci: use PCI_VGA_MMIO_SIZE, Gerd Hoffmann, 2018/05/22
- [Qemu-devel] [PATCH v2 1/6] vga: move bochs vbe defines to header file, Gerd Hoffmann, 2018/05/22
- [Qemu-devel] [PATCH v2 3/6] hw/display: add new bochs-display device, Gerd Hoffmann, 2018/05/22
- [Qemu-devel] [PATCH v2 4/6] bochs-display: add dirty tracking support, Gerd Hoffmann, 2018/05/22