Re: [Qemu-devel] [PATCH] Add save/load/del[vm] QMP api

[Eric Blake]

On 05/22/2018 01:59 AM, Pavel Balaev wrote:
> Hello,
>
> Now savevm, loadvm and delvm commands only allowed from hmp monitor.
> This patch adds ability to send them via QMP api.

Quoting my reply from an earlier similar proposal:
https://lists.gnu.org/archive/html/qemu-devel/2018-01/msg01864.html

> Straightforward mapping of the existing HMP commands into QMP without
> any thought about the design won't make the errors any clearer. My
> argument is that any QMP design for managing internal snapshots must be
> well-designed, but that since we discourage internal snapshots, no one
> has been actively working on that design.

Or an even earlier series that also attempted the same thing, and was 
rejected:
https://lists.gnu.org/archive/html/qemu-devel/2016-01/msg02427.html

You need to actually propose a sane design, and not just a mapping of 
the (awkward) HMP commands into blindly identical QMP commands.


> +# @savevm:
> +#
> +# Save a VM snapshot. Without a name new snapshot is created.
> +#
> +# @name: identifier of a snapshot to be saved
> +#
> +# Returns: Nothing on success
> +#
> +# Since: 2.12

Furthermore, you've missed the 2.12 release.  The next release will be 
3.0 (although you'll find mentions of 2.13 throughout list archives, as 
the decision to use 3.0 instead of 2.13 as the next release is fairly 
recent).

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org