[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 1/5] nbd/server: fix trace
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v3 1/5] nbd/server: fix trace |
Date: |
Wed, 23 May 2018 13:57:54 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 05/23/2018 05:24 AM, Vladimir Sementsov-Ogievskiy wrote:
Return code = 1 doesn't mean that we parsed base:allocation. Move
trace point to appropriate place.
Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
---
nbd/server.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
@@ -768,10 +771,10 @@ static int nbd_meta_base_query(NBDClient *client,
NBDExportMetaContexts *meta,
}
if (strncmp(query, "allocation", alen) == 0) {
+ trace_nbd_negotiate_meta_query_parse("base:allocation");
meta->base_allocation = true;
}
It's probably worth tracing even when we successfully skip the request,
as in:
if (strncmp...) {
trace_nbd_negotiate_meta_query_parse("base:allocation");
meta->base_allocation = true;
} else {
trace_nbd_negotiate_meta_query_skip("unrecognized request %s", query);
}
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
- [Qemu-devel] [PATCH v3 0/5] NBD export bitmaps, Vladimir Sementsov-Ogievskiy, 2018/05/23
- [Qemu-devel] [PATCH v3 5/5] docs/interop: add nbd.txt, Vladimir Sementsov-Ogievskiy, 2018/05/23
- [Qemu-devel] [PATCH v3 2/5] nbd/server: add nbd_meta_empty_or_pattern helper, Vladimir Sementsov-Ogievskiy, 2018/05/23
- [Qemu-devel] [PATCH v3 4/5] qapi: new qmp command nbd-server-add-bitmap, Vladimir Sementsov-Ogievskiy, 2018/05/23
- [Qemu-devel] [PATCH v3 3/5] nbd/server: implement dirty bitmap export, Vladimir Sementsov-Ogievskiy, 2018/05/23
- [Qemu-devel] [PATCH v3 1/5] nbd/server: fix trace, Vladimir Sementsov-Ogievskiy, 2018/05/23
- Re: [Qemu-devel] [PATCH v3 1/5] nbd/server: fix trace,
Eric Blake <=