[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 1/4] monitor: rename out_lock to mon_lock
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v7 1/4] monitor: rename out_lock to mon_lock |
Date: |
Thu, 24 May 2018 13:14:55 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) |
Peter Xu <address@hidden> writes:
> On Thu, May 24, 2018 at 10:29:20AM +0200, Markus Armbruster wrote:
>> Peter Xu <address@hidden> writes:
>>
>> > The out_lock is protecting a few Monitor fields. In the future the
>> > monitor code will start to run in multiple threads. We are going to
>> > turn it into a bigger lock to protect not only the out buffer but also
>> > all the rest.
>>
>> Hmm, not sure about "all the rest": PATCH 3 marks a member as not
>> needing protection. Shall I change this to "most of the rest" when I
>> apply?
>
> Of course. :) Please feel free to touch up the commit message where
> necessary (this rule applies to all my patches). I fully trust your
> wordings.
Well, I don't, so I'll keep asking :)
> Thanks!
[Qemu-devel] [PATCH v7 4/4] monitor: add lock to protect mon_fdsets, Peter Xu, 2018/05/24