[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 04/32] xlnx-zdma: Add a model of the Xilinx ZynqM
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PULL 04/32] xlnx-zdma: Add a model of the Xilinx ZynqMP generic DMA |
Date: |
Fri, 25 May 2018 14:57:26 +0100 |
On 18 May 2018 at 18:19, Peter Maydell <address@hidden> wrote:
> From: Francisco Iglesias <address@hidden>
>
> Add a model of the generic DMA found on Xilinx ZynqMP.
> +static bool zdma_load_descriptor(XlnxZDMA *s, uint64_t addr, void *buf)
> +{
> + /* ZDMA descriptors must be aligned to their own size. */
> + if (addr % sizeof(XlnxZDMADescr)) {
> + qemu_log_mask(LOG_GUEST_ERROR,
> + "zdma: unaligned descriptor at %" PRIx64,
> + addr);
> + memset(buf, 0xdeadbeef, sizeof(XlnxZDMADescr));
Another Coverity issue (CID 1391286). memset() doesn't work like this:
its second argument is a byte, so passing anything larger than 255
doesn't make sense.
+ s->error = true;
+ return false;
+ }
thanks
-- PMM
- [Qemu-devel] [PULL 03/32] target/arm: Add the XML dynamic generation, (continued)
- [Qemu-devel] [PULL 03/32] target/arm: Add the XML dynamic generation, Peter Maydell, 2018/05/18
- [Qemu-devel] [PULL 02/32] target/arm: Add "_S" suffix to the secure version of a sysreg, Peter Maydell, 2018/05/18
- [Qemu-devel] [PULL 05/32] xlnx-zynqmp: Connect the ZynqMP GDMA and ADMA, Peter Maydell, 2018/05/18
- [Qemu-devel] [PULL 07/32] hw/arm/smmu-common: Fix coverity issue in get_block_pte_address, Peter Maydell, 2018/05/18
- [Qemu-devel] [PULL 09/32] target/arm: Add SVE decode skeleton, Peter Maydell, 2018/05/18
- [Qemu-devel] [PULL 06/32] hw/arm/smmuv3: Fix Coverity issue in smmuv3_record_event, Peter Maydell, 2018/05/18
- [Qemu-devel] [PULL 01/32] target/arm: Add "ARM_CP_NO_GDB" as a new bit field for ARMCPRegInfo type, Peter Maydell, 2018/05/18
- [Qemu-devel] [PULL 04/32] xlnx-zdma: Add a model of the Xilinx ZynqMP generic DMA, Peter Maydell, 2018/05/18
- [Qemu-devel] [PULL 08/32] target/arm: Introduce translate-a64.h, Peter Maydell, 2018/05/18
- [Qemu-devel] [PULL 11/32] target/arm: Implement SVE load vector/predicate, Peter Maydell, 2018/05/18
- [Qemu-devel] [PULL 19/32] target/arm: Implement SVE bitwise shift by wide elements (predicated), Peter Maydell, 2018/05/18
- [Qemu-devel] [PULL 12/32] target/arm: Implement SVE predicate test, Peter Maydell, 2018/05/18
- [Qemu-devel] [PULL 13/32] target/arm: Implement SVE Predicate Logical Operations Group, Peter Maydell, 2018/05/18
- [Qemu-devel] [PULL 10/32] target/arm: Implement SVE Bitwise Logical - Unpredicated Group, Peter Maydell, 2018/05/18
- [Qemu-devel] [PULL 18/32] target/arm: Implement SVE bitwise shift by vector (predicated), Peter Maydell, 2018/05/18
- [Qemu-devel] [PULL 24/32] target/arm: Implement SVE Stack Allocation Group, Peter Maydell, 2018/05/18
- [Qemu-devel] [PULL 20/32] target/arm: Implement SVE Integer Arithmetic - Unary Predicated Group, Peter Maydell, 2018/05/18
- [Qemu-devel] [PULL 14/32] target/arm: Implement SVE Predicate Misc Group, Peter Maydell, 2018/05/18