[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 07/16] ahci: make port write traces more descriptive
From: |
John Snow |
Subject: |
[Qemu-devel] [PATCH 07/16] ahci: make port write traces more descriptive |
Date: |
Fri, 25 May 2018 19:55:00 -0400 |
Signed-off-by: John Snow <address@hidden>
---
hw/ide/ahci.c | 4 +++-
hw/ide/trace-events | 3 ++-
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
index 1d93cd6806..61ac8e46c8 100644
--- a/hw/ide/ahci.c
+++ b/hw/ide/ahci.c
@@ -284,8 +284,8 @@ static void ahci_port_write(AHCIState *s, int port, int
offset, uint32_t val)
AHCIPortRegs *pr = &s->dev[port].port_regs;
enum AHCIPortReg regnum = offset / sizeof(uint32_t);
assert(regnum < (AHCI_PORT_ADDR_OFFSET_LEN / sizeof(uint32_t)));
+ trace_ahci_port_write(s, port, AHCIPortReg_lookup[regnum], offset, val);
- trace_ahci_port_write(s, port, offset, val);
switch (regnum) {
case AHCI_PORT_REG_LST_ADDR:
pr->lst_addr = val;
@@ -355,6 +355,8 @@ static void ahci_port_write(AHCIState *s, int port, int
offset, uint32_t val)
check_cmd(s, port);
break;
default:
+ trace_ahci_port_write_unimpl(s, port, AHCIPortReg_lookup[regnum],
+ offset, val);
break;
}
}
diff --git a/hw/ide/trace-events b/hw/ide/trace-events
index ffde28615f..458e4a3e80 100644
--- a/hw/ide/trace-events
+++ b/hw/ide/trace-events
@@ -69,7 +69,8 @@ ahci_irq_raise(void *s) "ahci(%p): raise irq"
ahci_irq_lower(void *s) "ahci(%p): lower irq"
ahci_check_irq(void *s, uint32_t old, uint32_t new) "ahci(%p): check irq
0x%08x --> 0x%08x"
ahci_trigger_irq(void *s, int port, const char *name, uint32_t val, uint32_t
old, uint32_t new, uint32_t effective) "ahci(%p)[%d]: trigger irq +%s (0x%08x);
irqstat: 0x%08x --> 0x%08x; effective: 0x%08x"
-ahci_port_write(void *s, int port, int offset, uint32_t val) "ahci(%p)[%d]:
port write @ 0x%x: 0x%08x"
+ahci_port_write(void *s, int port, const char *reg, int offset, uint32_t val)
"ahci(%p)[%d]: port write [reg:%s] @ 0x%x: 0x%08x"
+ahci_port_write_unimpl(void *s, int port, const char *reg, int offset,
uint32_t val) "ahci(%p)[%d]: unimplemented port write [reg:%s] @ 0x%x: 0x%08x"
ahci_mem_read_32(void *s, uint64_t addr, uint32_t val) "ahci(%p): mem read @
0x%"PRIx64": 0x%08x"
ahci_mem_read(void *s, unsigned size, uint64_t addr, uint64_t val) "ahci(%p):
read%u @ 0x%"PRIx64": 0x%016"PRIx64
ahci_mem_write(void *s, unsigned size, uint64_t addr, uint64_t val) "ahci(%p):
write%u @ 0x%"PRIx64": 0x%016"PRIx64
--
2.14.3
- [Qemu-devel] [PATCH 00/16] AHCI: tracing improvements, John Snow, 2018/05/25
- [Qemu-devel] [PATCH 05/16] ahci: combine identical clauses in port write, John Snow, 2018/05/25
- [Qemu-devel] [PATCH 10/16] ahci: fix host register max address, John Snow, 2018/05/25
- [Qemu-devel] [PATCH 08/16] ahci: delete old port register address definitions, John Snow, 2018/05/25
- [Qemu-devel] [PATCH 07/16] ahci: make port write traces more descriptive,
John Snow <=
- [Qemu-devel] [PATCH 06/16] ahci: modify ahci_port_write to use register numbers, John Snow, 2018/05/25
- [Qemu-devel] [PATCH 13/16] ahci: fix spacing damage on ahci_mem_write, John Snow, 2018/05/25
- [Qemu-devel] [PATCH 09/16] ahci: add host register enumeration, John Snow, 2018/05/25
- [Qemu-devel] [PATCH 04/16] ahci: fix spacing damage on ahci_port_write, John Snow, 2018/05/25
- [Qemu-devel] [PATCH 16/16] ahci: make ahci_mem_write traces more descriptive, John Snow, 2018/05/25
- [Qemu-devel] [PATCH 11/16] ahci: modify ahci_mem_read_32 to work on register numbers, John Snow, 2018/05/25
- [Qemu-devel] [PATCH 02/16] ahci: modify ahci_port_read to use register numbers, John Snow, 2018/05/25
- [Qemu-devel] [PATCH 03/16] ahci: make port read traces more descriptive, John Snow, 2018/05/25