[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-block] [PATCH 04/14] block/create: Make x-blockde
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [Qemu-block] [PATCH 04/14] block/create: Make x-blockdev-create a job |
Date: |
Tue, 29 May 2018 17:40:02 +0200 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
Am 29.05.2018 um 17:27 hat Jeff Cody geschrieben:
> On Fri, May 25, 2018 at 06:33:17PM +0200, Kevin Wolf wrote:
> > This changes the x-blockdev-create QMP command so that it doesn't block
> > the monitor and the main loop any more, but starts a background job that
> > performs the image creation.
> >
>
> This comes down to "user error", but now that the monitor and main loop are
> not blocked (which is good), should we try at all to catch/prevent a
> blockdev-add that is issued before a blockdev-create completion?
Hm, currently, the .bdrv_co_create implementations usually do this:
blk = blk_new(BLK_PERM_WRITE | BLK_PERM_RESIZE, BLK_PERM_ALL);
I'm not sure if BLK_PERM_ALL is the best options for the shared
permissions, but anyway format drivers can't share BLK_PERM_WRITE on
their part, so I think we already do prevent this by taking the
BLK_PERM_WRITE permission.
Kevin
- Re: [Qemu-devel] [PATCH 03/14] job: Add error message for failing jobs, (continued)
- [Qemu-devel] [PATCH 01/14] vdi: Fix vdi_co_do_create() return value, Kevin Wolf, 2018/05/25
- [Qemu-devel] [PATCH 05/14] qemu-iotests: Add VM.get_qmp_events_filtered(), Kevin Wolf, 2018/05/25
- [Qemu-devel] [PATCH 04/14] block/create: Make x-blockdev-create a job, Kevin Wolf, 2018/05/25
- [Qemu-devel] [PATCH 07/14] qemu-iotests: Add iotests.img_info_log(), Kevin Wolf, 2018/05/25
- [Qemu-devel] [PATCH 06/14] qemu-iotests: Add VM.qmp_log(), Kevin Wolf, 2018/05/25
Re: [Qemu-devel] [Qemu-block] [PATCH 06/14] qemu-iotests: Add VM.qmp_log(), Jeff Cody, 2018/05/29
[Qemu-devel] [PATCH 10/14] qemu-iotests: Rewrite 210 for blockdev-create job, Kevin Wolf, 2018/05/25