Re: [Qemu-devel] [PATCH] ui/cocoa: Suppress NSFileHandlingPanelOKButton deprecation warning

[Peter Maydell]

On 29 May 2018 at 18:52, Programmingkid <address@hidden> wrote:
>
>> On May 25, 2018, at 6:26 AM, Peter Maydell <address@hidden> wrote:
>>
>> OSX 10.13 deprecates the NSFileHandlingPanelOKButton constant, and
>> would rather you use NSModalResponseOK, which was introduced in OS 10.9.
>> Use the recommended new constant name, with a backward compatibility
>> define if we're building on an older OSX.
>>
>> Signed-off-by: Peter Maydell <address@hidden>
>> ---
>> Tested on 10.13; I don't hvae anything older to test on.

>
> Sorry but this patch does not work with Mac OS 10.6. The MAC_OS_X_VERSION_10_9
> constant is not defined. I did make a patch that does work. It will be sent 
> shortly.

Oops, yes, we need to add the
#ifndef MAC_OS_X_VERSION_10_9
#define MAC_OS_X_VERSION_10_9 1090
#endif

I hadn't noticed that we only defined the ones of those we currently use.

Thanks for testing.

-- PMM