Re: [Qemu-devel] [PATCH v9 7/7] monitor: add lock to protect mon_fdsets

[Stefan Hajnoczi]

On Tue, May 29, 2018 at 01:57:55PM +0800, Peter Xu wrote:
> Introduce a new global big lock for mon_fdsets.  Take it where needed.
> 
> The monitor_fdset_get_fd() handling is a bit tricky: now we need to call
> qemu_mutex_unlock() which might pollute errno, so we need to make sure
> the correct errno be passed up to the callers.  To make things simpler,
> we let monitor_fdset_get_fd() return the -errno directly when error
> happens, then in qemu_open() we move it back into errno.
> 
> Signed-off-by: Peter Xu <address@hidden>
> ---
>  monitor.c     | 52 +++++++++++++++++++++++++++++++++++++++++----------
>  stubs/fdset.c |  2 +-
>  util/osdep.c  |  3 ++-
>  3 files changed, 45 insertions(+), 12 deletions(-)

Reviewed-by: Stefan Hajnoczi <address@hidden>

signature.asc
Description: PGP signature