Re: [Qemu-devel] [PATCH 06/13] 9p: darwin: Address minor differences

[Keno Fischer]

Well, I do have the patch already to switch this and the other patterns,
so let me know if you want it or not ;).

On Thu, May 31, 2018 at 3:22 PM, Greg Kurz <address@hidden> wrote:
> On Thu, 31 May 2018 12:27:35 -0400
> Keno Fischer <address@hidden> wrote:
>
>> >> --- a/hw/9pfs/9p-local.c
>> >> +++ b/hw/9pfs/9p-local.c
>> >> @@ -67,7 +67,10 @@ int local_open_nofollow(FsContext *fs_ctx, const char 
>> >> *path, int flags,
>> >>          assert(*path != '/');
>> >>
>> >>          head = g_strdup(path);
>> >> -        c = strchrnul(path, '/');
>> >> +        /* equivalent to strchrnul(), but that is not available on 
>> >> Darwin */
>> >
>> > Please make a qemu_strchrnul() helper with a separate implementation for 
>> > Darwin
>> > then. I guess you can put it in this file since there aren't any other 
>> > users in
>> > the QEMU code base.
>>
>> There actually are, but they also use this pattern. Could you
>> suggest the best place to put this utility? I can submit a patch
>> to switch all instances of this pattern over.
>
> Oh if the pattern is already used in other places, it's probably not
> worth the pain... so please forget this :)