[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V8 10/17] qmp event: Add COLO_EXIT event to noti
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH V8 10/17] qmp event: Add COLO_EXIT event to notify users while exited COLO |
Date: |
Mon, 4 Jun 2018 17:23:15 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 06/03/2018 12:05 AM, Zhang Chen wrote:
From: zhanghailiang <address@hidden>
If some errors happen during VM's COLO FT stage, it's important to
notify the users of this event. Together with 'x-colo-lost-heartbeat',
Users can intervene in COLO's failover work immediately.
If users don't want to get involved in COLO's failover verdict,
it is still necessary to notify users that we exited COLO mode.
Signed-off-by: zhanghailiang <address@hidden>
Signed-off-by: Li Zhijian <address@hidden>
Signed-off-by: Zhang Chen <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
---
migration/colo.c | 31 +++++++++++++++++++++++++++++++
qapi/migration.json | 38 ++++++++++++++++++++++++++++++++++++++
2 files changed, 69 insertions(+)
diff --git a/migration/colo.c b/migration/colo.c
index c083d3696f..bedb677788 100644
--- a/migration/colo.c
+ /*
+ * There are only two reasons we can go here, some error happened.
+ * Or the user triggered failover.
s/go here/get here/
s/happened. Or/happened, or/
+++ b/qapi/migration.json
@@ -880,6 +880,44 @@
{ 'enum': 'FailoverStatus',
'data': [ 'none', 'require', 'active', 'completed', 'relaunch' ] }
+##
+# @COLO_EXIT:
+#
+# Emitted when VM finishes COLO mode due to some errors happening or
+# at the request of users.
+#
+# @mode: report COLO mode when COLO exited.
+#
+# @reason: describes the reason for the COLO exit.
+#
+# Since: 2.13
s/2.13/3.0/
+#
+# Example:
+#
+# <- { "timestamp": {"seconds": 2032141960, "microseconds": 417172},
+# "event": "COLO_EXIT", "data": {"mode": "primary", "reason": "request" }
}
+#
+##
+{ 'event': 'COLO_EXIT',
+ 'data': {'mode': 'COLOMode', 'reason': 'COLOExitReason' } }
+
+##
+# @COLOExitReason:
+#
+# The reason for a COLO exit
+#
+# @none: no failover has ever happened, This can't occur in the COLO_EXIT
event,
s/happened,/happened./
+# only in the result of query-colo-status.
+#
+# @request: COLO exit is due to an external request
+#
+# @error: COLO exit is due to an internal error
+#
+# Since: 2.13
s/2.13/3.0/
+##
+{ 'enum': 'COLOExitReason',
+ 'data': [ 'none', 'request', 'error' ] }
+
##
# @x-colo-lost-heartbeat:
#
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
- [Qemu-devel] [PATCH V8 03/17] colo-compare: use notifier to notify packets comparing result, (continued)
- [Qemu-devel] [PATCH V8 03/17] colo-compare: use notifier to notify packets comparing result, Zhang Chen, 2018/06/03
- [Qemu-devel] [PATCH V8 04/17] COLO: integrate colo compare with colo frame, Zhang Chen, 2018/06/03
- [Qemu-devel] [PATCH V8 05/17] COLO: Add block replication into colo process, Zhang Chen, 2018/06/03
- [Qemu-devel] [PATCH V8 06/17] COLO: Remove colo_state migration struct, Zhang Chen, 2018/06/03
- [Qemu-devel] [PATCH V8 07/17] COLO: Load dirty pages into SVM's RAM cache firstly, Zhang Chen, 2018/06/03
- [Qemu-devel] [PATCH V8 08/17] ram/COLO: Record the dirty pages that SVM received, Zhang Chen, 2018/06/03
- [Qemu-devel] [PATCH V8 09/17] COLO: Flush memory data from ram cache, Zhang Chen, 2018/06/03
- [Qemu-devel] [PATCH V8 10/17] qmp event: Add COLO_EXIT event to notify users while exited COLO, Zhang Chen, 2018/06/03
- Re: [Qemu-devel] [PATCH V8 10/17] qmp event: Add COLO_EXIT event to notify users while exited COLO,
Eric Blake <=
- [Qemu-devel] [PATCH V8 11/17] qapi: Add new command to query colo status, Zhang Chen, 2018/06/03
- Re: [Qemu-devel] [PATCH V8 11/17] qapi: Add new command to query colo status, Markus Armbruster, 2018/06/07