Re: [Qemu-devel] [PATCH 06/13] block: Add block-specific QDict header

[Markus Armbruster]

Markus Armbruster <address@hidden> writes:

> Markus Armbruster <address@hidden> writes:
>
>> MAINTAINERS files include/block/qdict.h under "Block layer core".  Let's
>> split qobject/qdict.c as well, so it's there, too.  Obvious patch
>> appended.  Feel free to squash it into yours without giving me credit
>> for it.
>
> Hmm, we should split tests/check-qdict.c for the same reason.  Updated
> patch appended.
>
>> PS: I tried to move block-qdict.c to block/, but totally failed at
>> persuading Make to link it into all programs that need it.  Oh well.
>
>
> From bdb7f6581a3066db853bca6c81cc2c42f6cec8e9 Mon Sep 17 00:00:00 2001
> From: Markus Armbruster <address@hidden>
> Date: Wed, 6 Jun 2018 15:11:54 +0200
> Subject: [PATCH] qobject: Move block-specific qdict code to block-qdict.c
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>  MAINTAINERS               |   1 +
>  qobject/Makefile.objs     |   1 +
>  qobject/block-qdict.c     | 637 ++++++++++++++++++++++++++++++++++++
>  qobject/qdict.c           | 629 ------------------------------------
>  tests/Makefile.include    |   4 +
>  tests/check-block-qdict.c | 657 ++++++++++++++++++++++++++++++++++++++
>  tests/check-qdict.c       | 642 -------------------------------------
>  7 files changed, 1300 insertions(+), 1271 deletions(-)
>  create mode 100644 qobject/block-qdict.c
>  create mode 100644 tests/check-block-qdict.c
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 41cd3736a9..9f9835e052 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1365,6 +1365,7 @@ F: qemu-img*
>  F: qemu-io*
>  F: tests/qemu-iotests/
>  F: util/qemu-progress.c
> +F: qobject/block-qdict.c
>  T: git git://repo.or.cz/qemu/kevin.git block
>  
>  Block I/O path

Forgot to update MAINTAINERS for tests/check-block-qdict.c.  Fixup:

diff --git a/MAINTAINERS b/MAINTAINERS
index 9f9835e052..21f4bc1806 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1366,6 +1366,7 @@ F: qemu-io*
 F: tests/qemu-iotests/
 F: util/qemu-progress.c
 F: qobject/block-qdict.c
+F: test/check-block-qdict.c
 T: git git://repo.or.cz/qemu/kevin.git block
 
 Block I/O path

[...]