[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] monitor: postpone monitor_qmp_cleanup_queues
From: |
Peter Xu |
Subject: |
Re: [Qemu-devel] [PATCH] monitor: postpone monitor_qmp_cleanup_queues |
Date: |
Fri, 8 Jun 2018 17:24:57 +0800 |
User-agent: |
Mutt/1.9.5 (2018-04-13) |
On Fri, Jun 08, 2018 at 05:11:54PM +0800, Peter Xu wrote:
[...]
> Frankly speaking I think this might be an ideal fix as well. For
> example what if we are executing the dispatcher of a command when we
> received the CLOSED event? If so, the dispatcher will put the
> response onto the response queue after the CLOSED event, and ideally
> we'd better also deliver that to the filter_output process.
Please ignore this paragraph. Actually if that happens, we'll queue
the response onto the response queue as usual, then as long as the
output channel is not closed it'll still be delivered to the
filter_output process.
So I think I agree with Markus's solution, we just flush the response
queue when we get CLOSED (but we don't close the output fd; IMHO
that's chardev backend's job). Would that work?
Regards,
--
Peter Xu
- [Qemu-devel] [PATCH] monitor: postpone monitor_qmp_cleanup_queues, Peter Xu, 2018/06/04
- Re: [Qemu-devel] [PATCH] monitor: postpone monitor_qmp_cleanup_queues, Marc-André Lureau, 2018/06/04
- Re: [Qemu-devel] [PATCH] monitor: postpone monitor_qmp_cleanup_queues, Markus Armbruster, 2018/06/07
- Re: [Qemu-devel] [PATCH] monitor: postpone monitor_qmp_cleanup_queues, Peter Xu, 2018/06/08
- Re: [Qemu-devel] [PATCH] monitor: postpone monitor_qmp_cleanup_queues, Markus Armbruster, 2018/06/08
- Re: [Qemu-devel] [PATCH] monitor: postpone monitor_qmp_cleanup_queues, Stefan Hajnoczi, 2018/06/08
- Re: [Qemu-devel] [PATCH] monitor: postpone monitor_qmp_cleanup_queues, Markus Armbruster, 2018/06/08
- Re: [Qemu-devel] [PATCH] monitor: postpone monitor_qmp_cleanup_queues, Peter Xu, 2018/06/08
- Re: [Qemu-devel] [PATCH] monitor: postpone monitor_qmp_cleanup_queues,
Peter Xu <=
- Re: [Qemu-devel] [PATCH] monitor: postpone monitor_qmp_cleanup_queues, Markus Armbruster, 2018/06/11
- Re: [Qemu-devel] [PATCH] monitor: postpone monitor_qmp_cleanup_queues, Stefan Hajnoczi, 2018/06/11
- Re: [Qemu-devel] [PATCH] monitor: postpone monitor_qmp_cleanup_queues, Peter Xu, 2018/06/12
- Re: [Qemu-devel] [PATCH] monitor: postpone monitor_qmp_cleanup_queues, Stefan Hajnoczi, 2018/06/13
- Re: [Qemu-devel] [PATCH] monitor: postpone monitor_qmp_cleanup_queues, Peter Xu, 2018/06/13