Re: [Qemu-devel] [PATCH v4] cutils: Provide strchrnul

[Daniel P . Berrangé]

On Mon, Jun 11, 2018 at 09:52:55AM +0100, Peter Maydell wrote:
> On 11 June 2018 at 08:56, Markus Armbruster <address@hidden> wrote:
> > You're not printing $strchrnul like we print other configuration
> > results.  Hmm, we're not printing several of them.  Question for
> > maintainers (MAINTAINERS doesn't have any, so I'm cc'ing the top three
> > coughed up by get_maintainer.pl): bug or feature?  If feature, how do we
> > decide what to print?
> 
> If we printed everything that we tested for then the output would
> be unhelpfully enormous. My view is that we should print the
> "interesting" things for the user, ie the higher-level things
> that the user could potentially turn on by installing more
> libraries or has turned off explicitly or whatever. Reporting
> whether the host OS has strchrnul or whether we've had to
> provide our own implementation is doubly uninteresting:
>  * there's nothing the user could do to change this
>  * there is no visible effect (missing features, worse performance)
> 
> There's an argument that we should also log every config check
> result somehow (I think autoconf configures do this), but I
> don't think that our 'print stuff to stdout' is the right place
> for that.

If you look at most non-trivial apps using autoconf, they have soo many
checks printed out, that they end up having to manually print out a
summary of the "important stuff" at the end so users can actually see
something they have a chance of reading.   QEMU's configure output
is essentially equivalent to this summary data, which is good.

It is sometimes useful to know the answer of individual checks, but
if we really wanted todo that, we should just create a logfile for
that info, or just write more into our existing config.log file.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|