[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Improve file-backed RAM
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH] Improve file-backed RAM |
|
Date: |
Tue, 12 Jun 2018 05:20:28 -1000 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 06/06/2018 08:13 AM, Lingfeng Yang via Qemu-devel wrote:
> size_t qemu_mempath_getpagesize(const char *mem_path)
> {
> +#ifndef _WIN32
> #ifdef CONFIG_LINUX
> struct statfs fs;
> int ret;
> @@ -73,10 +82,14 @@ size_t qemu_mempath_getpagesize(const char *mem_path)
> #endif
>
> return getpagesize();
> +#else
> + return WIN_FILE_PAGE_SIZE;
> +#endif
> }
As a rule, positive tests are easier to read than negative ones. And when it
comes to nesting ifdefs, doubly so.
r~