[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] MAINTAINERS: Add an entry for qemu-options* fil
Re: [Qemu-devel] [PATCH] MAINTAINERS: Add an entry for qemu-options* files in main directory
Wed, 13 Jun 2018 14:37:32 +0200
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0
On 13/06/2018 08:23, Markus Armbruster wrote:
>>> Do you think you could still be available as (co-)maintainer of that new
>>> section? If not, who are going to be the maintainers of that new
>>> section? Paolo? Eric? Daniel? ...?
>> Well, currently it's going through me. I'd add vl.c too, by the way.
> vl.c has much more than just CLI parsing. It's pushing 4kSLOC...
Not much more though. There is some main loop / runstate stuff which
could be split to its own file, but it's perhaps 2-300 lines of code.
The rest is main() and its dependencies. Actually 1/3rd of it is main(). :)
> Splitting it up would be nice. As long as it's not, I guess the
> pragmatic solution is to have multiple MAINTAINERS sections claim it:
> existing "Main loop", proposed "CLI", ...
That would work too.