[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 5/7] hmp: Add info commands for preconfig
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH v3 5/7] hmp: Add info commands for preconfig |
Date: |
Wed, 13 Jun 2018 10:44:23 -0300 |
User-agent: |
Mutt/1.9.2 (2017-12-15) |
On Tue, Jun 12, 2018 at 09:00:20AM +0200, Markus Armbruster wrote:
> Igor Mammedov <address@hidden> writes:
>
> > On Mon, 11 Jun 2018 15:40:16 -0300
> > Eduardo Habkost <address@hidden> wrote:
> >
> >> On Mon, Jun 11, 2018 at 02:01:52PM +0200, Markus Armbruster wrote:
> >> > * Eduardo, why does "info numa" have no QMP equivalent?
> >>
> >> Nobody ever asked for one, which seems to qualify as "only for
> >> human users".
> >>
> >> Should we add an equivalent QMP command even if we don't expect
> >> anybody to use it?
>
> The hard requirement for QMP from day one was "provide everything
> machine clients need". To avoid speculation and endless arguments about
> what might be needed / not needed, we resolved to approximate this by
> "provide everything, except stuff that's *clearly* of no use to
> machines".
>
> When you think a command is such an exception, you should explain why in
> its commit message.
It's not an exception nor it needs to be one. I was just not
aware of the above approximation.
>
> Note that HMP need not provide the functionality in the exact same
> packaging. For instance, it's fine to have building blocks in QMP, and
> just a high-level command in HMP. However, the latter must be
> implemented with the building blocks to make it obvious that QMP
> provides the same functionality.
>
> For additional references, see
> Message-ID: <address@hidden>
> https://lists.nongnu.org/archive/html/qemu-devel/2018-06/msg02176.html
>
> > we inderectly can fetch numa info via QMP, using
> > query-hotpluggable-cpus
> > for CPU mapping and
> > query-memory-devices
> > for (NV|PC)-dimm devices, however there is no QMP way for getting
> > for numa mapping of initial RAM nor configured numa nodes
> > (not counting querying CLI options).
>
> Sounds like most of the building blocks are already there. The
> "obviousness" isn't.
>
> > So perhaps we need info 'numa' equivalent for QMP which would give
> > the same amount of information as HMP in one query.
>
> I'd appreciate patches to get us to "QMP has the building blocks, and
> HMP is implemented with them".
Agreed.
--
Eduardo
- Re: [Qemu-devel] [PATCH v3 5/7] hmp: Add info commands for preconfig, (continued)
- Re: [Qemu-devel] [PATCH v3 5/7] hmp: Add info commands for preconfig, Markus Armbruster, 2018/06/12
- Re: [Qemu-devel] [PATCH v3 5/7] hmp: Add info commands for preconfig, Dr. David Alan Gilbert, 2018/06/12
- Re: [Qemu-devel] [PATCH v3 5/7] hmp: Add info commands for preconfig, Eduardo Habkost, 2018/06/11
- Re: [Qemu-devel] [PATCH v3 5/7] hmp: Add info commands for preconfig, Igor Mammedov, 2018/06/11
- Re: [Qemu-devel] [PATCH v3 5/7] hmp: Add info commands for preconfig, Markus Armbruster, 2018/06/12
- Re: [Qemu-devel] [PATCH v3 5/7] hmp: Add info commands for preconfig,
Eduardo Habkost <=
- Re: [Qemu-devel] [PATCH v3 5/7] hmp: Add info commands for preconfig, Daniel P . Berrangé, 2018/06/12
[Qemu-devel] [PATCH v3 1/7] hmp: Add flag for preconfig commands, Dr. David Alan Gilbert (git), 2018/06/08
[Qemu-devel] [PATCH v3 4/7] qmp: enable query-[chardev|version|name|uuid|iothreads|memdev] commands in preconfig state, Dr. David Alan Gilbert (git), 2018/06/08
[Qemu-devel] [PATCH v3 6/7] hmp: add exit_preconfig, Dr. David Alan Gilbert (git), 2018/06/08