[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v0 2/2] qmp: add block-set-copy-on-read command

From: Max Reitz
Subject: Re: [Qemu-devel] [PATCH v0 2/2] qmp: add block-set-copy-on-read command
Date: Wed, 13 Jun 2018 18:41:14 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0

On 2018-06-13 18:02, Eric Blake wrote:
> On 06/13/2018 10:47 AM, Denis Plotnikov wrote:
>> The command enables/disables copy-on-read mode for VM's disk while
>> VM is running.
>> This is needed when using external disk readers to shape access pattern
>> to the disk backend.
>> Signed-off-by: Denis Plotnikov <address@hidden>
>> ---
> Deferring thoughts on the actual design for later;

But why? ;-)

This patch would definitely be superseded by a block reconfiguration
command (i.e. presumably one that makes reopen accessible over QMP).
With such a command, you could insert or remove a copy-on-read filter
node at any point in time.

Since we definitely want block graph configuration, I don't think we
want to add special commands now.


Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]