[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 02/12] migration: fix counting normal page for c

From: Xiao Guangrong
Subject: Re: [Qemu-devel] [PATCH 02/12] migration: fix counting normal page for compression
Date: Thu, 14 Jun 2018 11:32:17 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0

On 06/13/2018 11:51 PM, Dr. David Alan Gilbert wrote:
* address@hidden (address@hidden) wrote:
From: Xiao Guangrong <address@hidden>

The compressed page is not normal page

Is this the right reason?

I think the 'normal' page shouldn't include the compressed
page and XBZRLE-ed page (the current code does not treat
xbzrle pages are normal as well).

I think we always increment some counter for a page - so
what gets incremented for a compressed page?

In the later patch, we will introduce the statistics of
compression which contains "pages":
   @pages: amount of pages compressed and transferred to the target VM

Is the real answer that we do:


and control_save_page already increments the counter?

No :), control_save_page increments the counter only if it posted
data out, under that case, the compression path is not invoked.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]