[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 2/2] intel-iommu: start to use error_report_o
Re: [Qemu-devel] [PATCH v4 2/2] intel-iommu: start to use error_report_once
Thu, 14 Jun 2018 13:56:22 +0100
On 14 June 2018 at 13:51, Markus Armbruster <address@hidden> wrote:
> Auger Eric <address@hidden> writes:
>> On 06/13/2018 10:05 AM, Markus Armbruster wrote:
>>> Peter Xu <address@hidden> writes:
>>>> Replace existing trace_vtd_err() with error_report_once() then stderr
>>>> will capture something if any of the error happens, meanwhile we don't
>>>> suffer from any DDOS. Then remove the trace point. Since at it,
>>>> provide more information where proper (now we can pass parameters into
>>>> the report function).
>>>> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
>>>> Signed-off-by: Peter Xu <address@hidden>
>>>> hw/i386/intel_iommu.c | 59 ++++++++++++++++++++++++-------------------
>>>> hw/i386/trace-events | 1 -
>>>> 2 files changed, 33 insertions(+), 27 deletions(-)
>>> Michael, would you give your Reviewed-by or Acked-by? I'd take the
>>> series through my tree then.
>> Sorry to enter this thread at this late stage. Just one question: on the
>> smmuv3 emulation code, Peter (Maydell) urged me to use
>> qemu_log_mask(LOG_GUEST_ERROR, ...) whenever the error was triggered by
>> a guest bad behavior. So what is the final guidance to avoid the DOS you
> Does the user need to know about the error condition?
> If yes, we should tell him. Logging is not telling.
> Peter, what do you think?
My view is that "guest does something stupid" should be
LOG_GUEST_ERROR, because (a) maybe you'd like to know about it
but (b) usually you don't unless you happen to be the person
trying to develop or debug the guest OS, in which case you can
turn on the logging to help you in that debugging task.