[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 3/3] qcow2: add compress threads

From: Denis V. Lunev
Subject: Re: [Qemu-devel] [PATCH 3/3] qcow2: add compress threads
Date: Thu, 14 Jun 2018 16:19:52 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0

On 06/14/2018 04:16 PM, Kevin Wolf wrote:
> Am 08.06.2018 um 21:20 hat Vladimir Sementsov-Ogievskiy geschrieben:
>> Do data compression in separate threads. This significantly improve
>> performance for qemu-img convert with -W (allow async writes) and -c
>> (compressed) options.
>> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> Looks correct to me, but why do we introduce a separate
> MAX_COMPRESS_THREADS? Can't we simply leave the maximum number of
> threads to the thread poll?
> I see that you chose a much smaller number here (4 vs. 64), but is there
> actually a good reason for this?
> Kevin
yes. In the other case the guest will suffer much more from this increased
activity and load on the host.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]