Re: [Qemu-devel] [PATCH v14 3/6] i386: Disable TOPOEXT feature on pc-2.12

[Eduardo Habkost]

On Wed, Jun 13, 2018 at 09:18:24PM -0400, Babu Moger wrote:
> Disable TOPOEXT feature for older machines.
> 
> Signed-off-by: Babu Moger <address@hidden>
> ---
>  include/hw/i386/pc.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
> index 04d1f8c..ecccf6b 100644
> --- a/include/hw/i386/pc.h
> +++ b/include/hw/i386/pc.h
> @@ -303,6 +303,10 @@ bool e820_get_entry(int, uint32_t, uint64_t *, uint64_t 
> *);
>          .driver   = TYPE_X86_CPU,\
>          .property = "legacy-cache",\
>          .value    = "on",\
> +    },{\
> +        .driver   = TYPE_X86_CPU,\
> +        .property = "topoext",\
> +        .value    = "off",\
>      },

This is OK, if combined with the first hunks of patch 2/6.

-- 
Eduardo