[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 10/18] block-qdict: Simplify qdict_flatten_qdict(
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH v2 10/18] block-qdict: Simplify qdict_flatten_qdict() |
Date: |
Thu, 14 Jun 2018 21:14:35 +0200 |
There's no need to restart the loop. We don't elsewhere, e.g. in
qdict_extract_subqdict(), qdict_join() and qemu_opts_absorb_qdict().
Simplify accordingly.
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Kevin Wolf <address@hidden>
---
qobject/block-qdict.c | 18 +++---------------
1 file changed, 3 insertions(+), 15 deletions(-)
diff --git a/qobject/block-qdict.c b/qobject/block-qdict.c
index 41f39abc4a..f32df343e8 100644
--- a/qobject/block-qdict.c
+++ b/qobject/block-qdict.c
@@ -89,16 +89,13 @@ static void qdict_flatten_qdict(QDict *qdict, QDict
*target, const char *prefix)
QObject *value;
const QDictEntry *entry, *next;
char *new_key;
- bool delete;
entry = qdict_first(qdict);
while (entry != NULL) {
-
next = qdict_next(qdict, entry);
value = qdict_entry_value(entry);
new_key = NULL;
- delete = false;
if (prefix) {
new_key = g_strdup_printf("%s.%s", prefix, entry->key);
@@ -109,27 +106,18 @@ static void qdict_flatten_qdict(QDict *qdict, QDict
*target, const char *prefix)
* itself disappears. */
qdict_flatten_qdict(qobject_to(QDict, value), target,
new_key ? new_key : entry->key);
- delete = true;
+ qdict_del(qdict, entry->key);
} else if (qobject_type(value) == QTYPE_QLIST) {
qdict_flatten_qlist(qobject_to(QList, value), target,
new_key ? new_key : entry->key);
- delete = true;
+ qdict_del(qdict, entry->key);
} else if (prefix) {
/* All other objects are moved to the target unchanged. */
qdict_put_obj(target, new_key, qobject_ref(value));
- delete = true;
- }
-
- g_free(new_key);
-
- if (delete) {
qdict_del(qdict, entry->key);
-
- /* Restart loop after modifying the iterated QDict */
- entry = qdict_first(qdict);
- continue;
}
+ g_free(new_key);
entry = next;
}
}
--
2.17.1
- [Qemu-devel] [PATCH v2 12/18] block-qdict: Clean up qdict_crumple() a bit, (continued)
- [Qemu-devel] [PATCH v2 12/18] block-qdict: Clean up qdict_crumple() a bit, Markus Armbruster, 2018/06/14
- [Qemu-devel] [PATCH v2 02/18] iscsi: Drop deprecated -drive parameter "filename", Markus Armbruster, 2018/06/14
- [Qemu-devel] [PATCH v2 14/18] check-block-qdict: Rename qdict_flatten()'s variables for clarity, Markus Armbruster, 2018/06/14
- [Qemu-devel] [PATCH v2 09/18] block: Make remaining uses of qobject input visitor more robust, Markus Armbruster, 2018/06/14
- [Qemu-devel] [PATCH v2 11/18] block-qdict: Tweak qdict_flatten_qdict(), qdict_flatten_qlist(), Markus Armbruster, 2018/06/14
- [Qemu-devel] [PATCH v2 18/18] rbd: New parameter key-secret, Markus Armbruster, 2018/06/14
- [Qemu-devel] [PATCH v2 03/18] block: Add block-specific QDict header, Markus Armbruster, 2018/06/14
- [Qemu-devel] [PATCH v2 13/18] block-qdict: Simplify qdict_is_list() some, Markus Armbruster, 2018/06/14
- [Qemu-devel] [PATCH v2 15/18] check-block-qdict: Cover flattening of empty lists and dictionaries, Markus Armbruster, 2018/06/14
- [Qemu-devel] [PATCH v2 10/18] block-qdict: Simplify qdict_flatten_qdict(),
Markus Armbruster <=
- [Qemu-devel] [PATCH v2 07/18] block: Clean up a misuse of qobject_to() in .bdrv_co_create_opts(), Markus Armbruster, 2018/06/14
- [Qemu-devel] [PATCH v2 08/18] block: Factor out qobject_input_visitor_new_flat_confused(), Markus Armbruster, 2018/06/14
- [Qemu-devel] [PATCH v2 16/18] block: Fix -blockdev / blockdev-add for empty objects and arrays, Markus Armbruster, 2018/06/14
- [Qemu-devel] [PATCH v2 17/18] rbd: New parameter auth-client-required, Markus Armbruster, 2018/06/14
- [Qemu-devel] [PATCH v2 06/18] block: Fix -drive for certain non-string scalars, Markus Armbruster, 2018/06/14
- [Qemu-devel] [PATCH v2 05/18] block: Fix -blockdev for certain non-string scalars, Markus Armbruster, 2018/06/14
- [Qemu-devel] [PATCH v2 04/18] qobject: Move block-specific qdict code to block-qdict.c, Markus Armbruster, 2018/06/14
- Re: [Qemu-devel] [PATCH v2 00/18] block: Configuration fixes and rbd authentication, Kevin Wolf, 2018/06/15