[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] hw/isa/smc37c669: Change the parallel I/O base

From: Mark Cave-Ayland
Subject: Re: [Qemu-devel] [PATCH] hw/isa/smc37c669: Change the parallel I/O base to 378H
Date: Fri, 15 Jun 2018 08:25:58 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0

On 15/06/18 00:39, Philippe Mathieu-Daudé wrote:

On the Alpha DP264 machine, the Cirrus VGA is I/O mapped
in the 3C0H-3CFH range, thus I/O base used by the parallel
device clashes, and since a4cb773928e the VGA is not

(qemu) info mtree
address-space: memory
   0000000000000000-ffffffffffffffff (prio 0, i/o): system
     00000801fc000000-00000801fdffffff (prio 0, i/o): pci0-io
       00000801fc0003b4-00000801fc0003b5 (prio 0, i/o): vga
       00000801fc0003ba-00000801fc0003ba (prio 0, i/o): vga
       00000801fc0003bc-00000801fc0003c3 (prio 0, i/o): parallel
                                     ^^^                ^^^^^^^^
       00000801fc0003c0-00000801fc0003cf (prio 0, i/o): vga
       00000801fc0003d4-00000801fc0003d5 (prio 0, i/o): vga
       00000801fc0003da-00000801fc0003da (prio 0, i/o): vga

As there is no particular reason to use this base address
(introduced in 7bea0dd434e), change to 378H which is the
default on PC machines.

Reported-by: Emilio G. Cota <address@hidden>
Suggested-by: Paolo Bonzini <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
RFC: http://lists.nongnu.org/archive/html/qemu-devel/2018-06/msg04011.html

  hw/isa/smc37c669-superio.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/isa/smc37c669-superio.c b/hw/isa/smc37c669-superio.c
index aa233c6967..64466a9373 100644
--- a/hw/isa/smc37c669-superio.c
+++ b/hw/isa/smc37c669-superio.c
@@ -37,7 +37,7 @@ static bool is_parallel_enabled(ISASuperIODevice *sio, 
uint8_t index)
static uint16_t get_parallel_iobase(ISASuperIODevice *sio, uint8_t index)
-    return 0x3bc;
+    return 0x378;
static unsigned int get_parallel_irq(ISASuperIODevice *sio, uint8_t index)

Reviewed-by: Mark Cave-Ayland <address@hidden>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]