[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 04/10] migration/block-dirty-bitmap: fix dirty_bitmap
From: |
Dr. David Alan Gilbert (git) |
Subject: |
[Qemu-devel] [PULL 04/10] migration/block-dirty-bitmap: fix dirty_bitmap_load |
Date: |
Fri, 15 Jun 2018 16:15:12 +0100 |
From: Vladimir Sementsov-Ogievskiy <address@hidden>
dirty_bitmap_load_header return code is obtained but not handled. Fix
this.
Bug was introduced in b35ebdf076d697bc
"migration: add postcopy migration of dirty bitmaps" with the whole
function.
Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: John Snow <address@hidden>
Signed-off-by: Dr. David Alan Gilbert <address@hidden>
---
migration/block-dirty-bitmap.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/migration/block-dirty-bitmap.c b/migration/block-dirty-bitmap.c
index eeccaff34b..3bafbbdc4c 100644
--- a/migration/block-dirty-bitmap.c
+++ b/migration/block-dirty-bitmap.c
@@ -672,6 +672,9 @@ static int dirty_bitmap_load(QEMUFile *f, void *opaque, int
version_id)
do {
ret = dirty_bitmap_load_header(f, &s);
+ if (ret < 0) {
+ return ret;
+ }
if (s.flags & DIRTY_BITMAP_MIG_FLAG_START) {
ret = dirty_bitmap_load_start(f, &s);
--
2.17.1
- [Qemu-devel] [PULL 00/10] migration queue, Dr. David Alan Gilbert (git), 2018/06/15
- [Qemu-devel] [PULL 01/10] typedefs: add QJSON, Dr. David Alan Gilbert (git), 2018/06/15
- [Qemu-devel] [PULL 02/10] migration: Fixes for non-migratable RAMBlocks, Dr. David Alan Gilbert (git), 2018/06/15
- [Qemu-devel] [PULL 03/10] migration: Poison ramblock loops in migration, Dr. David Alan Gilbert (git), 2018/06/15
- [Qemu-devel] [PULL 04/10] migration/block-dirty-bitmap: fix dirty_bitmap_load,
Dr. David Alan Gilbert (git) <=
- [Qemu-devel] [PULL 05/10] migration: fix counting xbzrle cache_miss_rate, Dr. David Alan Gilbert (git), 2018/06/15
- [Qemu-devel] [PULL 06/10] migration: introduce migration_update_rates, Dr. David Alan Gilbert (git), 2018/06/15
- [Qemu-devel] [PULL 09/10] migration/postcopy: Wake rate limit sleep on postcopy request, Dr. David Alan Gilbert (git), 2018/06/15
- [Qemu-devel] [PULL 07/10] migration/postcopy: Add max-postcopy-bandwidth parameter, Dr. David Alan Gilbert (git), 2018/06/15
- [Qemu-devel] [PULL 08/10] migration: Wake rate limiting for urgent requests, Dr. David Alan Gilbert (git), 2018/06/15
- [Qemu-devel] [PULL 10/10] migration: calculate expected_downtime with ram_bytes_remaining(), Dr. David Alan Gilbert (git), 2018/06/15
- Re: [Qemu-devel] [PULL 00/10] migration queue, Peter Maydell, 2018/06/15