Re: [Qemu-devel] [PATCH v5 1/2] qapi: allow empty branches in flat unions

[Markus Armbruster]

Anton Nefedov <address@hidden> writes:

> It often happens that just a few discriminator values imply extra data in
> a flat union. Existing checks did not make possible to leave other values
> uncovered. Such cases had to be worked around by either stating a dummy
> (empty) type or introducing another (subset) discriminator enumeration.
>
> Both options create redundant entities in qapi files for little profit.
>
> With this patch it is not necessary anymore to add designated union
> fields for every possible value of a discriminator enumeration.
>
> Signed-off-by: Anton Nefedov <address@hidden>

Reviewed-by: Markus Armbruster <address@hidden>