Re: [Qemu-devel] [PATCH] block/crypto: Simplify block_crypto_{open, create}_opts_init()

[Eric Blake]

On 06/14/2018 09:29 AM, Markus Armbruster wrote:
> block_crypto_open_opts_init() and block_crypto_create_opts_init()
> contain a virtual visit of QCryptoBlockOptions and
> QCryptoBlockCreateOptions less member "format", respectively.
>
> Change their callers to put member "format" in the QDict, so they can
> use the generated visitors for these types instead.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>   block/crypto.c | 95 ++++++--------------------------------------------
>   block/crypto.h |  8 ++---
>   block/qcow.c   |  5 ++-
>   block/qcow2.c  | 10 +++---
>   4 files changed, 18 insertions(+), 100 deletions(-)

Reviewed-by: Eric Blake <address@hidden>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org