|
From: | Eric Blake |
Subject: | Re: [Qemu-devel] [PATCH v5 1/6] nbd/server: fix trace |
Date: | Tue, 19 Jun 2018 13:39:09 -0500 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 06/09/2018 10:17 AM, Vladimir Sementsov-Ogievskiy wrote:
Return code = 1 doesn't mean that we parsed base:allocation. Use correct traces in both -parsed and -skipped cases. Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden> --- nbd/server.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/nbd/server.c b/nbd/server.c index 9e1f227178..8e02e077ec 100644 --- a/nbd/server.c +++ b/nbd/server.c @@ -741,7 +741,10 @@ static int nbd_negotiate_send_meta_context(NBDClient *client, * the current name, after the 'base:' portion has been stripped. * * Return -errno on I/O error, 0 if option was completely handled by - * sending a reply about inconsistent lengths, or 1 on success. */ + * sending a reply about inconsistent lengths, or 1 on success. + * + * Note: return code = 1 doesn't mean that we've parsed "base:allocation" + * namespace. It only means that there are no errors.*/
Space before comment tail (actually, the recent conversation on comment style says the tail should be on its own line...)
That's something I can tweak on commit. Reviewed-by: Eric Blake <address@hidden> -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
[Prev in Thread] | Current Thread | [Next in Thread] |