Re: [Qemu-devel] [PATCH v4 6/7] monitor: remove "x-oob", turn oob on by default

[Peter Xu]

On Wed, Jun 20, 2018 at 09:20:30AM +0200, Markus Armbruster wrote:
> Peter Xu <address@hidden> writes:
> 
> > On Tue, Jun 19, 2018 at 04:16:49PM +0200, Markus Armbruster wrote:
> >> Peter Xu <address@hidden> writes:
> >> 
> >> > There was a regression reported by Eric Auger before with OOB:
> >> >
> >> >   http://lists.gnu.org/archive/html/qemu-devel/2018-03/msg06231.html
> >> >
> >> > It is fixed in 951702f39c ("monitor: bind dispatch bh to iohandler
> >> > context", 2018-04-10).
> >> >
> >> > For the bug, we turned Out-Of-Band feature of monitors off for 2.12
> >> > release.  Now we turn that on again after the 2.12 release.
> >> 
> >> Relating what happened in the order it happened could be easier to
> >> understand.  Perhaps:
> >> 
> >>   OOB commands were introduced in commit cf869d53172.  Unfortunately, we
> >>   ran into a regression, and had to disable them by default for 2.12
> >>   (commit be933ffc23).
> >> 
> >>   The regression has since been fixed (commit 951702f39c7 "monitor: bind
> >>   dispatch bh to iohandler context").  Time to re-enable OOB.
> >
> > This indeed looks much nicer.
> >
> >> 
> >> > This patch partly reverts be933ffc23 (monitor: new parameter "x-oob"),
> >> > meanwhile turn it on again by default for non-MUX QMPs.  Note that we
> >> 
> >> "by default"?
> >
> > Did I mis-spell somewhere?
> 
> I was too terse, sorry.  Let me try again.
> 
> "By default" suggests there's a way for the user to switch it off.
> That's not the case.  I guess you mean something like
> 
>     This patch partly reverts be933ffc23 (monitor: new parameter "x-oob"),
>     and turns OOB on again for non-MUX QMPs.

I see!  Fixed, with your r-b kept.

Hmm.  A new version is coming.

Thanks,

-- 
Peter Xu