[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] hw/i386: Deprecate the machine types pc-0.10
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH v2] hw/i386: Deprecate the machine types pc-0.10 and pc-0.11 |
Date: |
Thu, 21 Jun 2018 04:37:45 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 21.06.2018 04:18, Thomas Huth wrote:
> The oldest machine type which is still used in a still maintained distro
> is a pc-0.12 based machine type in RHEL6, so everything that is older
> than pc-0.12 should not be used anymore. Thus let's deprecate pc-0.10
> and pc-0.11 so that we can finally remove them in a future release.
[...]
> @@ -3953,6 +3954,10 @@ int main(int argc, char **argv, char **envp)
> }
>
> machine_class = select_machine();
> + if (machine_class->deprecation_reason) {
> + error_report("Machine type '%s' is deprecated: %s",
> + machine_class->name, machine_class->deprecation_reason);
> + }
I just noticed that I need to check for !qtest_enabled() here, too,
otherwise these messages show up during "make check". I'll send a v3...
Thomas