Re: [Qemu-devel] [PATCH 0/9] spapr: Clean up pagesize handling

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH 0/9] spapr: Clean up pagesize handling

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
0c66386fb1 spapr: Don't rewrite mmu capabilities in KVM mode
787addd355 spapr: Limit available pagesizes to provide a consistent guest 
environment
f6b4366e24 target/ppc: Add ppc_hash64_filter_pagesizes()
143ee46ef0 spapr: Use maximum page size capability to simplify memory backend 
checking
7bb6e85e44 spapr: Maximum (HPT) pagesize property
7a43ed59ce target/ppc: Add kvmppc_hpt_needs_host_contiguous_pages() helper
9bff9c15e0 spapr: Add cpu_apply hook to capabilities
4c9c79b967 spapr: Compute effective capability values earlier
1321ab423b target/ppc: Allow cpu compatiblity checks based on type, not instance

=== OUTPUT BEGIN ===
Checking PATCH 1/9: target/ppc: Allow cpu compatiblity checks based on type, 
not instance...
Checking PATCH 2/9: spapr: Compute effective capability values earlier...
Checking PATCH 3/9: spapr: Add cpu_apply hook to capabilities...
Checking PATCH 4/9: target/ppc: Add kvmppc_hpt_needs_host_contiguous_pages() 
helper...
Checking PATCH 5/9: spapr: Maximum (HPT) pagesize property...
Checking PATCH 6/9: spapr: Use maximum page size capability to simplify memory 
backend checking...
Checking PATCH 7/9: target/ppc: Add ppc_hash64_filter_pagesizes()...
Checking PATCH 8/9: spapr: Limit available pagesizes to provide a consistent 
guest environment...
WARNING: line over 80 characters
#28: FILE: hw/ppc/spapr_caps.c:337:
+static bool spapr_pagesize_cb(void *opaque, uint32_t seg_pshift, uint32_t 
pshift)

total: 0 errors, 1 warnings, 45 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 9/9: spapr: Don't rewrite mmu capabilities in KVM mode...
ERROR: Error messages should not contain newlines
#212: FILE: target/ppc/kvm.c:505:
+"KVM can't supply 64kiB CI pages, which guest expects\n");

total: 1 errors, 0 warnings, 201 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden