[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] regression: sata cdrom boot broken
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] regression: sata cdrom boot broken |
|
Date: |
Thu, 21 Jun 2018 13:22:18 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 20/06/2018 20:15, Thomas Huth wrote:
> On 20.06.2018 13:07, Gerd Hoffmann wrote:
>> Hi,
>>
>> $subject says all. Noticed while testing the upcoming seabios update.
>> Reproducer:
>>
>> qemu-system-x86_64 -M q35 -m 4G -cdrom
>> Fedora-Workstation-Live-x86_64-28-1.1.iso
>
> Once this has been fixed, please add a regression test to tests/cdrom-test.c
> for this, so that it can not happen so easily again. A line like this
> should do the job:
>
> qtest_add_data_func("cdrom/boot/q35", "-M q35 -cdrom ", test_cdboot);
Nice! The patch I've sent fixes tests/ahci-test.c to match what the
code now does, but cdrom-test.c is also good.
Thanks,
Paolo