Re: [Qemu-devel] [PATCH v3 13/49] qapi-types: refactor variants handling

[Markus Armbruster]

Marc-André Lureau <address@hidden> writes:

> Generate variants objects outside gen_object(). This will allow to
> easily wrap gen_object() with ifcond_decorator in the following patch.

ifcond_decorator is no more, please update your commit message.

>
> gen_variants_objects() calls gen_object() for each variants, so it

s/for each variants/for each variant/

> remains guarded for each generated variant object.
>
> self._gen_type_cleanup(name) is factored out in _gen_object(), helping
> generated code to be wrapped by the same condition in the following
> patch.
>
> Signed-off-by: Marc-André Lureau <address@hidden>

I read this thrice, and I still fail to understand the second and third
paragraph.

I'm skipping this patch for now, because we might not need it; see
review of next patch.