[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 2/9] hmp-commands: use long for begin and length in d
From: |
Dr. David Alan Gilbert (git) |
Subject: |
[Qemu-devel] [PULL 2/9] hmp-commands: use long for begin and length in dump-guest-memory |
Date: |
Thu, 21 Jun 2018 17:47:20 +0100 |
From: Suraj Jitindar Singh <address@hidden>
The dump-guest-memory command is used to dump an area of guest memory
to a file, the piece of memory is specified by a begin address and
a length. These parameters are specified as ints and thus have a maximum
value of 4GB. This means you can't dump the guest memory past the first
4GB and instead get:
(qemu) dump-guest-memory tmp 0x100000000 0x100000000
'dump-guest-memory' has failed: integer is for 32-bit values
Try "help dump-guest-memory" for more information
This limitation is imposed in monitor_parse_arguments() since they are
both ints. hmp_dump_guest_memory() uses 64 bit quantities to store both
the begin and length values. Thus specify begin and length as long so
that the entire guest memory space can be dumped.
Signed-off-by: Suraj Jitindar Singh <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Signed-off-by: Dr. David Alan Gilbert <address@hidden>
---
hmp-commands.hx | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hmp-commands.hx b/hmp-commands.hx
index 0de7c4c29e..754620e411 100644
--- a/hmp-commands.hx
+++ b/hmp-commands.hx
@@ -1116,7 +1116,7 @@ ETEXI
{
.name = "dump-guest-memory",
- .args_type =
"paging:-p,detach:-d,zlib:-z,lzo:-l,snappy:-s,filename:F,begin:i?,length:i?",
+ .args_type =
"paging:-p,detach:-d,zlib:-z,lzo:-l,snappy:-s,filename:F,begin:l?,length:l?",
.params = "[-p] [-d] [-z|-l|-s] filename [begin length]",
.help = "dump guest memory into file 'filename'.\n\t\t\t"
"-p: do paging to get guest's memory mapping.\n\t\t\t"
--
2.17.1
- [Qemu-devel] [PULL 0/9] hmp queue, Dr. David Alan Gilbert (git), 2018/06/21
- [Qemu-devel] [PULL 2/9] hmp-commands: use long for begin and length in dump-guest-memory,
Dr. David Alan Gilbert (git) <=
- [Qemu-devel] [PULL 1/9] monitor: report entirety of hmp command on error, Dr. David Alan Gilbert (git), 2018/06/21
- [Qemu-devel] [PULL 3/9] hmp: Add flag for preconfig commands, Dr. David Alan Gilbert (git), 2018/06/21
- [Qemu-devel] [PULL 4/9] hmp: Allow help on preconfig commands, Dr. David Alan Gilbert (git), 2018/06/21
- [Qemu-devel] [PULL 5/9] hmp: Restrict auto-complete in preconfig, Dr. David Alan Gilbert (git), 2018/06/21
- [Qemu-devel] [PULL 6/9] qmp: Enable a few commands in preconfig state, Dr. David Alan Gilbert (git), 2018/06/21
- [Qemu-devel] [PULL 7/9] hmp: Add commands for preconfig, Dr. David Alan Gilbert (git), 2018/06/21
- [Qemu-devel] [PULL 9/9] hmp: Allow HMP in preconfig state again, Dr. David Alan Gilbert (git), 2018/06/21
- [Qemu-devel] [PULL 8/9] hmp: add exit_preconfig, Dr. David Alan Gilbert (git), 2018/06/21
- Re: [Qemu-devel] [PULL 0/9] hmp queue, Peter Maydell, 2018/06/22