[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 00/49] qapi: add #if pre-processor conditions
Re: [Qemu-devel] [PATCH v3 00/49] qapi: add #if pre-processor conditions to generated code
Fri, 22 Jun 2018 08:56:25 +0200
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
Marc-André Lureau <address@hidden> writes:
> On Thu, Jun 21, 2018 at 6:47 PM, Markus Armbruster <address@hidden> wrote:
>> I think we can bite off a digestible part of this series:
>> target-independent top-level conditionals. I think that's PATCH
>> 01-14,31 and applicable parts of 35-37. The idea is to merge that part
>> quickly, then deal with the (less daunting) remainder. Marc-André, if
>> you agree with that plan, please respin just that part. I can continue
>> review of the remainder without a rebase.
> That's ok with me, I'll work on it.
The next part could be target-dependend top-level conditionals, or
member conditionals (enum members are tied to union variants, which may
make further splitting impractical). This series does members first. I
guess we stick to that order to avoid unnecessary patch reordering work.