[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 1/1] s390/ipl: fix ipl with -no-reboot

From: David Hildenbrand
Subject: Re: [Qemu-devel] [PATCH v3 1/1] s390/ipl: fix ipl with -no-reboot
Date: Fri, 22 Jun 2018 12:10:59 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0

On 22.06.2018 12:10, Christian Borntraeger wrote:
> On 06/22/2018 11:59 AM, Paolo Bonzini wrote:
>> On 22/06/2018 11:46, Cornelia Huck wrote:
>>>>> Ok, then my suggestion made even more sense. :)  No other objections
>>>>> apart from the name of the constant.
>>>>> Paolo  
>>> Don't like that one much.
>>> Either that, or drop the 'S390' (is it conceivable that other
>>> architectures have something similar)?
>> I don't know exactly what is going on here, so I'm not very suited to
>> answer this.  The difference just from reading the C code seems to be
>> that it calls s390_cpu_load_normal instead of s390_ipl_prepare_cpu, and
>> that it calls subsystem_reset instead of qemu_devices_reset.
>> For a more generic name I'd go with SHUTDOWN_CAUSE_OS_BOOT (or
>> OS_BOOTING, or BOOT_OS), but an s390-specific name is of course fine as
>> well, especially if you have a specific moniker for the "thing that IPL
> It is not a BOOT, it is in fact an reset just to the devices.
> Right now I favor




David / dhildenb

reply via email to

[Prev in Thread] Current Thread [Next in Thread]