Re: [Qemu-devel] [PATCH v3 13/19] linux-user: Split out close, open, openat, read, write

[Richard Henderson]

On 06/22/2018 03:38 AM, Peter Maydell wrote:
>> +SYSCALL_IMPL(close)
>> +{
>> +    fd_trans_unregister(arg1);
>> +    return get_errno(close(arg1));
>> +}
>> +SYSCALL_DEF(close, ARG_DEC);
> 
> If in future we wanted to extend the set of information
> we had for each syscall in the SyscallDef struct, I guess
> we'd add parameters to the SYSCALL_DEF macro (or have
> more variant macros)? I can't offhand think of something I'd
> want to use that for, so it's a bit of an abstract question
> for the moment.

Yes, I imagine we'd extend the SYSCALL_DEF macro(s) in that case.

Another thought I've had is to define variant SYSCALL_IMPL<N> macros that would
allow us to put names to arguments, and help make the implementations clearer.
E.g.

SYSCALL_IMPL1(close, fd)
{
    fd_trans_unregister(fd);
    return get_errno(close(fd));
}


r~