[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/5] sm501: Perform a full update after palette

From: BALATON Zoltan
Subject: Re: [Qemu-devel] [PATCH 2/5] sm501: Perform a full update after palette change
Date: Fri, 22 Jun 2018 23:38:25 +0200 (CEST)
User-agent: Alpine 2.21 (BSF 202 2017-01-01)

On Fri, 22 Jun 2018, Sebastian Bauer wrote:
Am 2018-06-22 03:34, schrieb Philippe Mathieu-Daudé:
On 06/21/2018 05:08 AM, BALATON Zoltan wrote:
From: Sebastian Bauer <address@hidden>

Changing the palette of a color index has as an immediate effect on
all pixels with the corresponding index on real hardware. Performing a
full update after a palette change is a simple way to emulate this

Signed-off-by: Sebastian Bauer <address@hidden>
Signed-off-by: BALATON Zoltan <address@hidden>

    v4: Updated commit message

 hw/display/sm501.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/hw/display/sm501.c b/hw/display/sm501.c
index 0625cf5..a2ee6e3 100644
--- a/hw/display/sm501.c
+++ b/hw/display/sm501.c
@@ -479,6 +479,7 @@ typedef struct SM501State {
     MemoryRegion twoD_engine_region;
     uint32_t last_width;
     uint32_t last_height;
+    uint32_t do_full_update; /* perform a full update next time */

Can this be a bool?

Yes, this can be a bool. Let me know if you think that this is required.

I can take care of this in next submission, no need to resend the patch, I can change it to bool.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]