qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v5 09/35] target/arm: Implement SVE load and bro


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH v5 09/35] target/arm: Implement SVE load and broadcast element
Date: Mon, 25 Jun 2018 16:46:43 +0100

On 21 June 2018 at 02:53, Richard Henderson
<address@hidden> wrote:
> Signed-off-by: Richard Henderson <address@hidden>
> ---
>  target/arm/helper-sve.h    |  5 +++
>  target/arm/sve_helper.c    | 41 +++++++++++++++++++++++++
>  target/arm/translate-sve.c | 62 ++++++++++++++++++++++++++++++++++++++
>  target/arm/sve.decode      |  5 +++
>  4 files changed, 113 insertions(+)


> +/* Copy Zn into Zn, and store zero into inactive elements.  */
> +void HELPER(sve_movz_b)(void *vd, void *vn, void *vg, uint32_t desc)

Given the prototype, presumably "into Zd" ?

> +{
> +    intptr_t i, opr_sz = simd_oprsz(desc) / 8;
> +    uint64_t *d = vd, *n = vn;
> +    uint8_t *pg = vg;
> +    for (i = 0; i < opr_sz; i += 1) {
> +        d[i] = n[i] & expand_pred_b(pg[H1(i)]);
> +    }
> +}

otherwise
Reviewed-by: Peter Maydell <address@hidden>

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]