qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] osdep: work around Coverity parsing errors


From: Philippe Mathieu-Daudé
Subject: Re: [Qemu-devel] [PATCH] osdep: work around Coverity parsing errors
Date: Mon, 25 Jun 2018 13:24:49 -0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0

On 06/25/2018 01:06 PM, Paolo Bonzini wrote:
> Coverity does not like the new _Float* types that are used by
> recent glibc, and croaks on every single file that includes
> stdlib.h.  Add dummy typedefs to please it.

This matches http://gcc.gnu.org/onlinedocs/gcc-8.1.0/gcc/Floating-Types.html

> 
> Signed-off-by: Paolo Bonzini <address@hidden>

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

> ---
>       I've been using this patch for a couple months, and Peter pointed
>       out that other projects are doing similar hacks.  So it's probably
>       time to send it upstream.
> 
>       Note that this is a parse error, so it cannot be fixed in the
>       model file.
> 
>  include/qemu/osdep.h | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h
> index 9ed62423c0..0084f3fa71 100644
> --- a/include/qemu/osdep.h
> +++ b/include/qemu/osdep.h
> @@ -33,6 +33,14 @@
>  #else
>  #include "exec/poison.h"
>  #endif
> +#ifdef __COVERITY__
> +typedef float _Float32;
> +typedef double _Float32x;
> +typedef double _Float64;
> +typedef __float80 _Float64x;
> +typedef __float128 _Float128;
> +#endif
> +
>  #include "qemu/compiler.h"
>  
>  /* Older versions of C++ don't get definitions of various macros from
> 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]