[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 3/9] hw/mips/mips_malta: don't make bios region 'nomi
From: |
Aleksandar Markovic |
Subject: |
[Qemu-devel] [PULL 3/9] hw/mips/mips_malta: don't make bios region 'nomigrate' |
Date: |
Mon, 25 Jun 2018 22:05:58 +0200 |
From: Peter Maydell <address@hidden>
Currently we use memory_region_init_rom_nomigrate() to create
the "bios.1fc" memory region, and we don't manually register
it with vmstate_register_ram(). This currently means that its
contents are migrated but as a ram block whose name is the empty
string; in future it may mean they are not migrated at all. Use
memory_region_init_ram() instead.
Note that this is a a cross-version migration compatibility break
for the "malta" machine.
Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Cédric Le Goater <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Aleksandar Markovic <address@hidden>
---
hw/mips/mips_malta.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/mips/mips_malta.c b/hw/mips/mips_malta.c
index 494f84e..b9d92bf 100644
--- a/hw/mips/mips_malta.c
+++ b/hw/mips/mips_malta.c
@@ -1152,7 +1152,7 @@ void mips_malta_init(MachineState *machine)
* handled by an overlapping region as the resulting ROM code subpage
* regions are not executable.
*/
- memory_region_init_ram_nomigrate(bios_copy, NULL, "bios.1fc", BIOS_SIZE,
+ memory_region_init_ram(bios_copy, NULL, "bios.1fc", BIOS_SIZE,
&error_fatal);
if (!rom_copy(memory_region_get_ram_ptr(bios_copy),
FLASH_ADDRESS, BIOS_SIZE)) {
--
2.7.4
- [Qemu-devel] [PULL 0/9] Target MIPS queue, 2018-06-25, Aleksandar Markovic, 2018/06/25
- [Qemu-devel] [PULL 9/9] target/mips: Fix gdbstub to read/write 64 bit FP registers, Aleksandar Markovic, 2018/06/25
- [Qemu-devel] [PULL 3/9] hw/mips/mips_malta: don't make bios region 'nomigrate',
Aleksandar Markovic <=
- [Qemu-devel] [PULL 8/9] target/mips: Fix data type for offset, Aleksandar Markovic, 2018/06/25
- [Qemu-devel] [PULL 5/9] target/mips: Raise a RI when given fs is n/a from CTC1, Aleksandar Markovic, 2018/06/25
- [Qemu-devel] [PULL 2/9] hw/mips/boston: don't make flash region 'nomigrate', Aleksandar Markovic, 2018/06/25
- [Qemu-devel] [PULL 4/9] hw/pci-host/xilinx-pcie: don't make "io" region be RAM, Aleksandar Markovic, 2018/06/25
- [Qemu-devel] [PULL 6/9] target/mips: Fix microMIPS on reset, Aleksandar Markovic, 2018/06/25
- [Qemu-devel] [PULL 7/9] target/mips: Update gen_flt_ldst(), Aleksandar Markovic, 2018/06/25
- [Qemu-devel] [PULL 1/9] MAINTAINERS: update target-mips maintainers, Aleksandar Markovic, 2018/06/25
- Re: [Qemu-devel] [PULL 0/9] Target MIPS queue, 2018-06-25, Peter Maydell, 2018/06/26