[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 1/3] hw/block/fdc: Replace error_setg(&error_
Re: [Qemu-devel] [PATCH v4 1/3] hw/block/fdc: Replace error_setg(&error_abort) by assert()
Tue, 26 Jun 2018 09:19:55 +0200
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
John Snow <address@hidden> writes:
> On 06/25/2018 12:57 PM, Philippe Mathieu-Daudé wrote:
>> Use assert() instead of error_setg(&error_abort),
>> as suggested by the "qapi/error.h" documentation:
>> Please don't error_setg(&error_fatal, ...), use error_report() and
>> exit(), because that's more obvious.
>> Likewise, don't error_setg(&error_abort, ...), use assert().
>> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
>> Acked-by: John Snow <address@hidden>
> AIUI this series is to be merged by someone else currently, right?
> Nothing needed on my part?
Whatever doesn't get picked up by maintainers of patched code can go
through my tree.