[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] s390 qemu boot failure in -next

From: Christian Borntraeger
Subject: Re: [Qemu-devel] s390 qemu boot failure in -next
Date: Tue, 26 Jun 2018 10:54:41 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0

On 06/26/2018 10:29 AM, Cornelia Huck wrote:
>>>>          if (ipl->initrd) {
>>>>              ram_addr_t initrd_offset;
>>>> would put the command line in no matter what the start address is.  
>>> I'm for putting that one in (and backporting it to qemu-stable). It's a
>>> bit worrying, though, that our ipl code is so fragile...  
>> We actually have to combine this with Thomas fix (to check for rom_ptr 
>> returning
>> something sane). It seems that ipl->commandline is always there, so we have 
>> to
>> check for strlen!=0 it seems..
>> I mean if somebody ask for "-append something" we can certainly always write 
>> something
>> if there is rom/ram.
> Given that the uncompressed image is not supposed to be bootable
> anymore, does it make sense to add this anyway?

I think we can drop this patch for now.

> I'll go ahead and queue Thomas' fix, though.

yes, please

reply via email to

[Prev in Thread] Current Thread [Next in Thread]